sanic icon indicating copy to clipboard operation
sanic copied to clipboard

Published 20 hours ago • verified publisher icon sanic-org

Always show server location in ASGI

Open ahopkins opened this issue 1 year ago • 6 comments

Closes #2520

Co-authored-by: Adam Hopkins [email protected] Co-authored-by: Zhiwei Liang [email protected]

ahopkins avatar Aug 07 '22 20:08 ahopkins

Our CI is broken?

ChihweiLHBird avatar Aug 07 '22 20:08 ChihweiLHBird

Or our testing on this is not sufficient. But I thought we had ASGI lifespan triggers tested.

ahopkins avatar Aug 07 '22 22:08 ahopkins 

type-checking run-test-pre: PYTHONHASHSEED='3170477258'
type-checking run-test: commands[0] | mypy sanic
sanic/app.py:1317: error: Signature of "asgi" incompatible with supertype "RunnerMixin"
Found 1 error in 1 file (checked 83 source files)
ERROR: InvocationError for command /home/chihwei/sanic/.tox/type-checking/bin/mypy sanic (exited with code 1)
____________________________________________________________________________________________________________________________________ summary _____________________________________________________________________________________________________________________________________
ERROR:   type-checking: commands failed

Can you also try to close and reopen this PR to see if we can trigger the CI?

ChihweiLHBird avatar Aug 08 '22 00:08 ChihweiLHBird

Will when I push some tests. It just didn't because it was originally changing targets. That doesn't trigger.

ahopkins avatar Aug 08 '22 04:08 ahopkins

Is there any solution for this in the meantime? Or just stay with 22.3 version?

azimovMichael avatar Aug 09 '22 12:08 azimovMichael

Will be releasing this probably tomorrow if that helps.

ahopkins avatar Aug 09 '22 13:08 ahopkins

Codecov Report

Merging #2522 (d124cfa) into main (7827b1b) will increase coverage by 0.026%. The diff coverage is 87.500%.

@@              Coverage Diff              @@
##              main     #2522       +/-   ##
=============================================
+ Coverage   87.430%   87.457%   +0.026%     
=============================================
  Files           69        69               
  Lines         5577      5581        +4     
  Branches       969       969               
=============================================
+ Hits          4876      4881        +5     
+ Misses         509       508        -1     
  Partials       192       192
Impacted Files Coverage Δ
sanic/mixins/runner.py 94.736% <85.714%> (+0.462%) :arrow_up:
sanic/app.py 88.825% <100.000%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 17:08 codecov[bot]