sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

Y24 335 barcode for norm plate tests

Open dasunpubudumal opened this issue 1 year ago • 1 comments

Closes #

Changes proposed in this pull request

  • Create a new request type and a submission for integrating the norm plate which is under the sequencing stage (not library prep). This new request type is used in Bespoke MX HiC pipeline config in https://github.com/sanger/limber/pull/2023.

We tried to do this without creating a new submission (i.e., with no new request types) but was unsuccessful as the Norm plate is an intermediary plate used in the sequencing stage and library types aren't really used after the library pass step (i.e., after library prep stage) to filter pipeline configs. Even if you can declare a library_type in the pipeline config in Limber it won't be used to filter the configs in sequencing stages of the pipeline configs (i.e., stages after library pass).

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

dasunpubudumal avatar Oct 24 '24 14:10 dasunpubudumal

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.57%. Comparing base (6bb4976) to head (d8e9543). Report is 94 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4456      +/-   ##
===========================================
+ Coverage    86.47%   86.57%   +0.09%     
===========================================
  Files         1390     1390              
  Lines        29771    29932     +161     
===========================================
+ Hits         25745    25913     +168     
+ Misses        4026     4019       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 24 '24 14:10 codecov[bot]

Thanks for the explanation, really helpful.

is an intermediary plate used in the sequencing stage

--> I would say "is an intermediary plate used in the multiplexing stage" (sequencing happens even later - after the final LB Lib Pool Norm tube is created)

KatyTaylor avatar Nov 01 '24 14:11 KatyTaylor