sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

The Great Prettier Linting

Open StephenHulme opened this issue 7 months ago • 2 comments

When Prettier was updated to version 3, a config was required to specify an plugins, such as https://github.com/prettier/plugin-ruby, that were used. This PR retrospectively adds this change, along with the subsequent linting.

Changes proposed in this pull request

  • Specify plugin-ruby in prettier config file
  • Add Ruby dependencies for plugin-ruby
  • Lint codebase

In some cases Prettier and Rubocop were fighting over who's formatting rules would win. I tried to defer to Rubocop by telling Prettier (STree) to ignore those lines, but in some cases the ignores failed, so I told Rubocop to ignore them instead. I think it is more important that linting is reenabled soon, than the style be completely consistent.

Related

See #4089 for the Rubocop equivalent of this PR.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

StephenHulme avatar Jul 04 '24 13:07 StephenHulme