sequencescape
sequencescape copied to clipboard
Y24-121 - As a developer (Ben) I would like there to be fine-grained batch creation validation for sequencing pipelines
User story As a developer (Ben) I would like there to be fine-grained batch creation validation for sequencing pipelines.
Currently batch validation for sequencing pipelines lives in a few places, default records, sequencing pipeline model, batch model. This implementation limits any new validation to be added as global validation to every batch (validation in batch.rb). However with some pipelines we want fine grained batch creation behaviour like NovaSeqX
The aim of this story is to enable custom/individual batch validation for each pipeline. There may be a few ways to do this and it may require some investigation prior to implementation. My suggested implementation:
- Adding a custom validator class for each required pipeline. This validator would be referenced in the pipeline config or similar. All existing pipelines could fall back on a 'standard' validator class which contains the existing validation. Then we add a validator class for each pipeline that requires custom validation.
- We would move the current pipeline/batch.rb validation to the 'standard' validator class.
- Ensure the batch creation javascript works with the updated methods. https://github.com/sanger/sequencescape/blob/develop/app/views/pipelines/show.html.erb contains some logic to fade out unusable requests when creating a batch and this should still work. Also consider whether this can refactored and allow us to use other logic ontop of batch size.
Who are the primary contacts for this story Ben T, Tris B
Who is the nominated tester for UAT Tris B
(May not need UAT as there should be noticeable difference)