sequencescape
sequencescape copied to clipboard
DPL-nnn [BUG] 'Limber-Htp - Multiplexing -' submissions should validate that they are being made on libraries [S=M,V=3]
Describe the bug The 'Limber-Htp - Multiplexing -' series of submissions are intended to allow re-pooling (or deferred pooling decisions) of already made libraries. However at the moment there is no validation, allowing submissions to be built on pre-library samples. If the user then uses something like other actions to apply tags, this can result in pools without a library_type on the aliquots. Not only that, but this will avoid the customer getting charged for library prep, which was probably undesirable.
Ideally we should prevent the user from building such submissions on any assets in which the aliquots are lacking library_type, with an error returned at the earliest opportunity. We can't rely on plate purpose, as oftern the SSR will have converted the plate to a seemingly appropriate point in the pipeline.
This isn't quite as straight forward as we may hope as:
- Multiplexing requests are also built upfront in library creation submissions, and will be lacking source-assets until someone charges-and passes libraries.
- Submission building is asynchronous, so by the time we're building the requests, the user has probably moved on.
Two options:
- Validation on the request type if assets has changed and is present to check the aliquots. This has the advantage that it could also detect premature charge and pass libraries, but the error feedback mechanisms in both cases are likely poor.
- Some kind of validator associated with the submission template. This would allow us to provide timely feedback in a somewhat isolated context, so is less likely to have unexpected side-effects. It would also potentially allow us to move things like the plate-purpose validation onto the submission templates, improving feedback and helping decouple request-types from plate purposes.
RT Ticket Number RT#750098
To Reproduce Steps to reproduce the behaviour:
- Go to page '...'
- Click on button '...'
- See error
Expected behaviour What was expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- Windows or Mac?
- Browser Chrome, Firefox, Safari or other?
- Browser version (use 'About' to look up)?
Additional context Add any other context about the problem here.