sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

DPL-nnn [BUG] Cherrypicking from the same source well mutliple times in the batch fails

Open JamesGlover opened this issue 2 years ago • 0 comments

Describe the bug If two requests in a batch come from the same source well, you are unable to start the batch. Instead you get a 500:

An AASM::InvalidTransition occurred in workflows#stage:

Event 'pass' cannot transition from 'passed'.

app/models/tasks/cherrypick_handler.rb:226:in `map'

I think this bug has been around for a while. If I recall correctly the layout interface actually references wells by asset_id, rather than request_id, so its probably going to touch a few layers to fix this. (Especially as you'll need to distinguish the two repeat wells to the user somehow)

RT Ticket Number If applicable

To Reproduce Steps to reproduce the behaviour:

  1. Go to page '...'
  2. Click on button '...'
  3. See error

Expected behaviour What was expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows or Mac?
  • Browser Chrome, Firefox, Safari or other?
  • Browser version (use 'About' to look up)?

Additional context Add any other context about the problem here.

JamesGlover avatar Apr 13 '22 10:04 JamesGlover