sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

DPL-nnn [BUG] If all requests in a batch are cancelled, this should be clearly communicated

Open JamesGlover opened this issue 3 years ago • 3 comments

Describe the bug If sequencing requests in a batch are cancelled then this can be a bit tricky to spot, and the user is still propted to continue with the batch. The Lims will throw a 500 when they attempt to process a step.

We should:

  • Present a clear message that all requests have been cancelled
  • Not display the steps to advance the batch
  • Provide a button to discard the batch (Double check this state is appropriate)

Current behaviour: Screenshot 2021-07-14 at 13 21 21

RT Ticket Number If applicable

To Reproduce Steps to reproduce the behaviour:

  1. Go to page '...'
  2. Click on button '...'
  3. See error

Expected behaviour What was expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows or Mac?
  • Browser Chrome, Firefox, Safari or other?
  • Browser version (use 'About' to look up)?

Additional context Add any other context about the problem here.

JamesGlover avatar Jul 14 '21 12:07 JamesGlover

Batch does provide update_batch_state which is used in a few places where batch requests can be cancelled as part of the batch interface to automatically transition a batch once all requests in it are either failed or cancelled. I'm not sure what the performance costs or practicalities of using this on state changes triggered by other means, hence why suggesting we should just present a button to 'discard' the batch.

JamesGlover avatar Jul 14 '21 12:07 JamesGlover

If a batch contains a mixture of canceled and pending/started requests, then the pending/started request should be released back to the inbox. (I think this may be a little tricky with sequencing requests, and I seem to remember what we usually do is actually create copies of the requests)

See the reset batch feature (on the edit page when a batch is unstarted) and the fail and remove items page for ideas.

JamesGlover avatar Jul 15 '21 14:07 JamesGlover

Added to the Sequencing pipelines milestone

JamesGlover avatar Jul 15 '21 14:07 JamesGlover