sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

BUG - Better handle CSV::MalformedCSVError

Open JamesGlover opened this issue 4 years ago • 0 comments

Describe the bug Upload of invalid CSVs for sample manifests can result in CSV::MalformedCSVError. Eg.

A CSV::MalformedCSVError occurred in sample_manifest_upload_with_tag_sequences#create:



  Invalid byte sequence in UTF-8 in line 26.

  app/sample_manifest_excel/sample_manifest_excel/upload/data.rb:90:in `find_start_row'

We should rescue these errors and return something useful to the user.

RT Ticket Number If applicable

To Reproduce Steps to reproduce the behaviour:

  1. Go to page '...'
  2. Click on button '...'
  3. See error

Expected behaviour What was expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows or Mac?
  • Browser Chrome, Firefox, Safari or other?
  • Browser version (use 'About' to look up)?

Additional context Add any other context about the problem here.

JamesGlover avatar Feb 24 '21 15:02 JamesGlover