sequencescape icon indicating copy to clipboard operation
sequencescape copied to clipboard

GPL-887 Prevent upload of 'empty' multiplexed library manifests (C:S, V: ?)

Open JamesGlover opened this issue 4 years ago • 0 comments

User story As an SSR I would like Sequencescape to prevent the upload of 'empty' multiplexed library manifests, as this is always an error.

Eg RT711061

** Background

  • Multiplexed library manifests used external library creation requests to handle the transfer from the library tubes into the multiplexed library.
  • This ensures we allocate a unique library id to each sample
  • Historically this was also required as samples and aliquots were created at manifest creation, not upload. Pooling was deferred to avoid tag clashes.
  • Transfer into the MX tube is handled by external library creation requests
  • These requests are passed then the manifest is uploaded, triggering the transfer

In addition, any rows which don't have a supplier sample name are considered 'empty' and in these cases the external library creation request is cancelled. These rows will be ignored on subsequent manifest uploads.

Reasoning for above:

  1. Sometimes a customer will be expecting to send a mx library of x samples, but failures in their own library creation process will mean they only end up suppling y samples.
  2. We prevent addition of extra samples on subsequent uploads due to the complexity of accurately propagating that information downstream. This includes: a) accurately detecting ALL transfers, as some older bits of Sequencescape don't use transfer requests b) Unclear how to handle invalid state introduced downstream (eg tag clashes)

Who are the primary contacts for this story e.g. John S (don't include surnames in public repos)

Acceptance criteria To be considered successful the solution must allow:

  • [ ] If I upload a multiplexed library manifest with no supplier sample names filled in, it should error, and not cancel the external library creation requests.

JamesGlover avatar Feb 02 '21 10:02 JamesGlover