Timofey Kachalov
Timofey Kachalov
We have the same problem with monorepo. We need to validate commit messages + PR title. I checked, `dangerjs` performs 12 requests in total. For example `/reviews` and `/requested_reviewers` requests....
@orta i understand. Right now seems https://github.com/danger/danger-js/pull/991 is the best way to solve this problem. Am i right?
Our `dangerfile.js` is very simple ``` const { schedule } = require('danger') const { conventionalCommits } = require('./commits') const { conventionalPRTitle } = require('./pr-title') schedule(conventionalCommits) schedule(conventionalPRTitle) ``` And each of...
Can you finish this, please?
Why diff includes changes of tis PR? https://github.com/ljharb/qs/pull/276
@daggerjames what you think?
PR: https://github.com/ljharb/qs/pull/316
Yes, existing code is important, but firstly, notation with brackets already correctly parsed, and inconsistence between stringify of array with single item and with multiple items can cause some real...
> he expected answer I believe is Qs.parse("foo[]=a,b", {comma: true}) // foo: ['a', 'b'] and Qs.parse("foo[]=a", {comma: true}) // foo: ['a']. And they are the current result. This, this is...
The confusion is around when comma is true, and there is no way to determine that value was array with single element, after `stringify`, because usually all code expect values...