monroe icon indicating copy to clipboard operation
monroe copied to clipboard

Connection issues with latest master when .nrepl-port is not present

Open yayitswei opened this issue 1 year ago • 3 comments

Just a heads up for folks discovering the project - the latest master has connection issues when working with projects without an .nrepl-port file.

Environment: GNU Emacs 29.4 on OSX

Details:

  • Error: "Wrong type argument: processp, nil" when trying to evaluate code
  • Root cause: monroe-connection returns nil because process name matching doesn't handle all cases
  • Debug shows two processes exist but aren't found:
    • "monroe" (status: run)
    • "monroe/localhost:7888" (status: open)
  • monroe-net-filter is attached to monroe/localhost:7888 but main REPL process uses default filter
  • monroe-session remains nil after connection

Workaround: Using commit 508f5ed0f88b0b5e01a37d456186ea437f44d93c which is known-good for this use case.

To use the working version with straight.el:

(straight-use-package
 '(monroe :type git
          :host github
          :repo "sanel/monroe"
          :commit "508f5ed0f88b0b5e01a37d456186ea437f44d93c"))

yayitswei avatar Nov 03 '24 05:11 yayitswei

Also, I wanted to express my appreciation - I've been using Monroe for a decade now! Thanks @sanel for writing such a solid and reliable piece of software. It was and still is a core part of my workflow.

yayitswei avatar Nov 03 '24 05:11 yayitswei

Thank you @yayitswei! I was planing to revert latest merges because I feel they are bit unstable. By reverting to 508f5ed0f88b0b5e01a37d456186ea437f44d93c, have you noticed any other issues? How long have you running 508f5ed0f88b0b5e01a37d456186ea437f44d93c in your setup?

sanel avatar Nov 03 '24 20:11 sanel

I've been using 508f5ed for about a week with no issues. Before that, I was using a version from 2016. To be fair, I'm sure most of the commits since then have been fine - I just haven't had time to bisect the issue.

yayitswei avatar Nov 04 '24 14:11 yayitswei