monroe icon indicating copy to clipboard operation
monroe copied to clipboard

Fix #29 - Report error when jump to definition doesn't find var

Open bbuccianti opened this issue 3 years ago • 4 comments

I know it's not the most elegant solution, but it's working.

Let me know if some changes are needed.

Thanks!

bbuccianti avatar Sep 25 '20 22:09 bbuccianti

With the last force-push I've added the lexical-binding: t as a file variable in order to use a closure in monroe-eval-jump. This work as a medium to have the var and ns we are looking for inside the callback.

Please let me know if changes are needed.

Thanks!

bbuccianti avatar Sep 27 '20 19:09 bbuccianti

I've added the closure for have ns on the calback, but never used it! My mistake. Now I think it's okay.

bbuccianti avatar Oct 01 '20 20:10 bbuccianti

Thank you for this! Can you just please show me example of what it tries to address?

sanel avatar Oct 13 '20 17:10 sanel

Sure!

On this issue #29 , you've added a sample implementation for a way to being able to jump to function definitions. I've just taked that, and make it work with current state of the project (monroe).

Personally, I've never used that feature, but a few tests showed that it's working properly. You just need to make a function and from a invocation you can try monroe-jump and you're there. In the case the function doesn't exist, the nrepl server return a exception and that's when we know that we can't jump to that function (I think). So it shows you with a message which function was looking for and in which namespace.

Let me know if this helps!

Thanks

bbuccianti avatar Oct 13 '20 22:10 bbuccianti