vscode-todotasks icon indicating copy to clipboard operation
vscode-todotasks copied to clipboard

Restrict hotkeys to files using tasks syntax

Open samuelmaddock opened this issue 8 years ago • 6 comments

After installing this plugin, I was unable to use the ctrl+enter hotkey to insert a new line in any editor view. I think this plugin's hotkeys should be limited to files using the tasks syntax if possible.

This would also fix the issue in #10

samuelmaddock avatar Sep 17 '16 19:09 samuelmaddock

@samuelmaddock Seems to me this is a full duplicate of #10, but in any case, I can't replicate the issue on VSCode 1.6.1, the command(insertLineAfter) is working properly after rebinding it in the keybinding.json file. vscode-todotasks version:

Version
0.4.0
Last updated
9/30/2016, 1:33:11 PM

This is both with and without having the alt+i command rebound to task.new.

dtasev avatar Oct 21 '16 18:10 dtasev

Had the same issue.

This:

                        {
                                "command": "task.new",
                                "key": "Ctrl+Enter",
                                "mac": "Cmd+Enter",
                                "when": "editorTextFocus"
                        }

essentially the base "Cmd+Enter" shortcut on VSCode as the "when" condition is exactly the same. Please add the language filter to the extensions shortcut.

kidoman avatar Nov 26 '16 07:11 kidoman

When I did #21, it fixed the keybindings to restrict them to only work if the language was set to todo (Tasks in the status bar). I noticed this fix wasn't working anymore - I applied it locally since 21 isn't approved. Removing the language restriction allowed the bindings to work again, and not interfering with other languages. Can anybody confirm? @Sandy081 can you comment if something changed on the backend?

rbenson avatar Jul 06 '17 20:07 rbenson

Yep, it broke for me too... i had to disable this extension for now.

kidoman avatar Jul 06 '17 20:07 kidoman

So after I posted, something changed because it broke again! I restarted VSC two times before posing

rbenson avatar Jul 06 '17 21:07 rbenson

Broken for me too. VSC 1.17.1 here

sveggiani avatar Oct 12 '17 17:10 sveggiani