Sameer Agarwal

are you using glog or miniglog?

Closing because of lack of response.

Cc:@joydeep-b

we should be able to fix this by moving to absl and using the more up to date implementation there I think.

cc: @joydeep-b cc: @S-o-T

One thing which is not clear is if we should be fetching inside the cmake file, or using googletest as a submodule the same way abseil recommends that it be...

@sergiud wdyt?

googletest is not supposed to be used as a library, they explicitly tell you not to do it, but rather have a copy of the source as part of your...

My question is, should we be including googletest as a git submodule or pull it using cmake's FetchContent. ``` include(FetchContent) FetchContent_Declare( googletest GIT_REPOSITORY https://github.com/google/googletest.git GIT_TAG release-1.12.1 ) # For Windows:...

Thanks @alexsmac I am not terribly well informed about the world outside google, so its good for me to learn the considerations here. I think the ODR violation concern for...