Sameer Agarwal

Results 143 comments of Sameer Agarwal

https://groups.google.com/g/google-glog/c/f8D7qpXLWXw The vmodule behaviour does not work on non-gcc compilers it seems.

Thanks Igor, I will take a look. I refactored the whole trust region minimizer loop some time ago and it is likely I changed the logic for the last iteration...

Igor as I suspected this discrepancy is an artifact of the trust region minimizer refactoring. To fix this properly, I will need to refactor the line search minimizer code along...

Yeah I suspect this is going to have to wait a while.

@mkraft89 thanks for bringing this up, its been a while since I looked at this code, but I will take a look.

Now that the logging library is part of abseil https://github.com/abseil/abseil-cpp/tree/master/absl/log we should be able to replace our use of gflags and glog with absl.

Hi @cdcseacave thank you for this pull request. Currently we do not accept pull requests on GithHub, could you submit this for review following the instructions at http://ceres-solver.org/contributing.html.

@sergiud do you want to send me a patch to the documentation pointing to your fork of suitesparse? Also @alexsmac may have some time to look at integrating intelmkl into...

I have not looked at the oneMKL API yet, its been changing a fair bit over the past two years. I will start another issue to discuss the cmake/suitesparse thing...