sandstone icon indicating copy to clipboard operation
sandstone copied to clipboard

Advancement criteria conditions have incorrect types for the `player` and `entity` properties

Open GrantGryczan opened this issue 3 years ago • 0 comments

The player property of any applicable advancement trigger's conditions should always accept an EntityCriterion, not only an array of predicates.

image

The player property also should not accept a single predicate that isn't in an array, which it does.

image

Additionally, the entity property of any applicable advancement trigger's conditions should always accept an array of predicates, not only an EntityCriterion.

Example advancement trigger from Minecraft wiki:

image

GrantGryczan avatar Dec 28 '21 23:12 GrantGryczan