sandstone icon indicating copy to clipboard operation
sandstone copied to clipboard

More conventional score method names

Open GrantGryczan opened this issue 3 years ago • 1 comments

Many of the current names are very unnatural to type and to read.

These should be renamed:

  • greaterOrEqualThan -> greaterThanOrEqualTo
  • lowerOrEqualThan -> lessThanOrEqualTo
  • lowerThan -> lessThan
  • equalTo -> equals
  • multipliedBy -> times
  • modulo -> mod
  • moduloBy -> modBy

Any of the last four could be aliases instead if that's preferable to renaming. The first three are completely unnatural phrasings though.

GrantGryczan avatar Dec 15 '21 05:12 GrantGryczan

I agree that the 4 last should be aliases, for consistency mostly.

TheMrZZ avatar Dec 15 '21 10:12 TheMrZZ