sandr01d
sandr01d
Looking further into this, I see the following options: 1. Add a `_forgit_git` function that simply runs git with the core.quotePath option set to false like this ```sh _forgit_git() {...
> I haven't understood, yet, why this happens in forgit but not with git directly. Where is the difference? We're calling git as well, so why does it behave differently?...
I don't have a strong opinion about splitting things into separate files either. That was just something that came to my mind when thinking about this. After reading your thoughts...
Implementing this is more difficult than I previously anticipated. The reason for this is that fzf starts an external process for every preview, as described [here](https://github.com/junegunn/fzf#preview-window). Meaning functions that are...
@carlfriedrich I did not include the deferred git commands that we did not end up creating functions for in this PR. Let me know whether you would like to have...
> I am not sure if I understand your problem correctly. Can you maybe share a piece of actual (non-working) code that we can comment on? > > Concerning exporting...
> Haven't looked into everything in detail, yet, but first thing I noticed is that [7657444](https://github.com/wfxr/forgit/commit/7657444632c8d0421d63838f318e03fa4dc35168) reverts some of the changes of #338. The array parsing in the functions gets...
> @sandr01d Yes, they are correctly added in the first commit of this PR ([1e8f79e](https://github.com/wfxr/forgit/commit/1e8f79edefe17b35bad55725973ed387e910ce73)), but the second commit ([7657444](https://github.com/wfxr/forgit/commit/7657444632c8d0421d63838f318e03fa4dc35168)) removes the calls from the `_forgit_git_*` functions again. Could you...
> @sandr01d Oh, I'm sorry! I viewed the patch on my tiny mobile phone screen, which obviously is not a good idea, and also I obviously did not read your...
> I would suggest to squash that commit into its parent. Done > I wonder if we could replace the four `xargs` calls with `for` loops, so that we do...