Sander van Hooft comments

Results 189 comments of


                                            Sander van Hooft

Retrying failed payment doesn't update cycle_ends_at on subscription

Hi @siegerhansma , Ok, let me double check that I am getting this right because there's a lot happening here: 1. Your billable model is on an active subscription. 2....

Retrying failed payment doesn't update cycle_ends_at on subscription

This here seems to be the culprit: https://github.com/mollie/laravel-cashier-mollie/blob/d8d5ba12ee0356eb8e66b3a11cd0072940e2af09/src/Subscription.php#L560-L575

Retrying failed payment doesn't update cycle_ends_at on subscription

@ciungulete can you pick this one up?

Retrying failed payment doesn't update cycle_ends_at on subscription

Thanks!

Remove money helper from code to stop collision

Hi @siegerhansma ! Thanks for this PR. Can you point me to the signature of the helper in the colliding package?

Remove money helper from code to stop collision

Thanks! It appears to me the helper itself isn't removed in this PR?

Remove money helper from code to stop collision

That would definitely help keeping things consistent :)

Remove money helper from code to stop collision

Related: #128 #89

Remove money helper from code to stop collision

Looks good to me! Thanks @siegerhansma !

Remove money helper from code to stop collision

Hi @RemiHin , Thanks for reporting and sorry to hear that. I was under the impression it was only used by Cashier internally. But I now see it's also used...