mini-typescript icon indicating copy to clipboard operation
mini-typescript copied to clipboard

fix when literal is string

Open hkc452 opened this issue 3 years ago • 5 comments

fix when the type of Literal Expression is string

hkc452 avatar Jun 08 '21 09:06 hkc452

It looks like you're trying the exercise to add string literals. A couple of comments:

  1. I haven't figured out how people should try the exercises. I can look at PRs here if you want.
  2. What you have is the addition you need for the checker, but for new syntax like string literals, you'll also need substantial additions in the types, lexer and parser.

sandersn avatar Jun 08 '21 14:06 sandersn

Maybe add some test & baseline files so beginners can try it out themselves? And enable discussion here?

Zzzen avatar Jul 10 '21 13:07 Zzzen

I guess documentation on how to debug tests on vscode would be helpful.

Zzzen avatar Jul 10 '21 13:07 Zzzen

Those are both really good ideas. I could make a branch that adds the tests and baselines and then people could fork from that branch.

I haven't actually debugged mini-typescript -- just console.log debugging -- so it'll take me some fiddling to get that set up, but it's definitely needed.

sandersn avatar Jul 12 '21 15:07 sandersn

#12 kicks off discussions

sandersn avatar Jul 15 '21 23:07 sandersn