Sander Lienaerts

Results 35 comments of Sander Lienaerts

PR with running tests: https://github.com/OCA/sale-workflow/pull/3259

May be closed, `stock_restrict_lot` was merged in https://github.com/OCA/stock-logistics-workflow/pull/1652

Hi @legalsylvain, is it possible to get this one merged?

> Hi @joepsanders : could you take a look if [#2899 (review)](https://github.com/OCA/web/pull/2899#pullrequestreview-2207211141) is still present, and try to fix it if not ? > > web_responsive should be installed. >...

@legalsylvain can we push this forward?

Can you squash ee62b63f7b9b5a4e1ce96e597c617f5195090ce5 into ecbb2ce5e3a8a634c76de13dd5e36191903faea9? Why do we change the contribution lines `The migration of this module from 16.0 to 17.0 was financially supported by Camptocamp`?

It's okay to have the contribution mentioned. However it's historical and therefore no reason to change :)

Functional check is working as expected 👍

@pedrobaeza hi Pedro, could you attend Josep's comment about the failing tests? Any idea? @Josep-s73 one last request would be to squash the administrative comments, as guided here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

The OCA-git-bot failed to tag you @SMaciasOSI, so here follows again