sander2

Results 65 comments of sander2

Hmm I'm not completely convinced by this approach - both on the parachain side and on the client side this needs special handling. If we go with the issue/redeem approach,...

Otherwise if we're ok with special handling on vault side then we might as well keep the current approach of having a special `replace` type, since arguably that keeps the...

Yup agreed, just a small note that we don't need the `pub redeemer: AccountOrVault,` change - the request already contains the vaultid so if `issue_id` is set, you can just...

Related: a long time ago we also looked into getting code coverage info in the CI. I remember it worked, but we never integrated it

If compound is using simple interest, why don't we do the same?

LDOT is already registered

To quote Philipp: > The current blocker is the price sourcing though. vDOT is not available on coingecko and DIA is still working on implementing the price feed for vDOT....

@gregdhill we have a lot of issues and redeems to migrate, I'm worried we might not have enough capacity in a single block. I've heard stories of chain getting stuck...

As discussed, we are parking this for now. I just wanted to record one thought I had on this pr: issue and redeem periods are different, we need to make...

@justin-elementlabs assuming that this is still an issue, I think it might be caused by you using `executor::block_on`: https://github.com/elementlabs42/BitVM-playground/blob/e102f23d88fee5c46f8e6f86442f371e857016ba/src/bridge/client/data_store/sftp.rs#L208 .If you call the function from a regular async function in...