arduino-LoRa icon indicating copy to clipboard operation
arduino-LoRa copied to clipboard
verified publisher icon sandeepmistry

Private declarations that should be public in LoRa.h

Open NicHub opened this issue 1 year ago • 1 comments

In LoRa.h, are you sure you want the declarations from lines¹ 97 to 115 to be private? I especially need readRegister to be public but the other declarations can also be useful for end users.

¹ Line numbers of version 0.8.0 on PlatformIO: https://registry.platformio.org/libraries/sandeepmistry/LoRa/versions

NicHub avatar Aug 07 '24 13:08 NicHub

Indeed. I move manually read/writeRegister to public...

Kongduino avatar Aug 07 '24 14:08 Kongduino