playwright-ct-web icon indicating copy to clipboard operation
playwright-ct-web copied to clipboard
verified publisher icon sand4rt

Not possible to test using attributes

Open rstoneIDBS opened this issue 2 years ago • 3 comments

I'm just trying out your library and have found that its not possible to set attributes on components, some of our components don't map properties to attributes so can't be tested. I've created a very small patch to fix this if you are interested in pulling it in.

rstoneIDBS avatar Apr 21 '23 15:04 rstoneIDBS

@rstoneIDBS Awesome, would be great!

sand4rt avatar Apr 21 '23 16:04 sand4rt

@rstoneIDBS Awesome, would be great!

I'm not entirely sure how to get this to you - do I need to fork this repo? Edit: I tried to create a branch but wasn't allowed.

rstoneIDBS avatar Apr 21 '23 16:04 rstoneIDBS

Yeah, you will need to:

  1. Fork the repo
  2. Clone the forked repo
  3. Create a branch
  4. Commit the changes (using conventional commit) eg. fix: render attributes
  5. Go to the PR section in GitHub and you are able to create the PR there

sand4rt avatar Apr 21 '23 16:04 sand4rt