ember-cli-page-object icon indicating copy to clipboard operation
ember-cli-page-object copied to clipboard

V2 beta

Open ro0gr opened this issue 4 years ago • 5 comments

ro0gr avatar Nov 22 '20 10:11 ro0gr

I've got a bunch of time before the end of the year to spend on open source work, I'd be happy to help with anything you need to move v2 out the door @ro0gr. It sounds like from #359 you mostly have it locally, but let me know if there's anything I can do to help or test.

jrjohnson avatar Dec 21 '21 04:12 jrjohnson

@jrjohnson Hey 👋 First, sorry for this huge delay.. And I really appreciate your will to help here!

So as I said before there is a PR containing a different efforts(it's public finally https://github.com/san650/ember-cli-page-object/pull/556). The ember upgrade part is definitely incoimplete(but contains a lot of tests cleanup), so I think it's the best candidate to be extracted into a dedicated PR. We could even go a step further and upgrade to ember-source@4(should be a matter of few dummy files upgrade). Meanwhile, I'm currently focused to make embroider really work.

I understand the year is almost over, you are probably busy with some other activity. However, if you are still interested, feel free to reach me in the ember discord for the further coordination!

ro0gr avatar Dec 28 '21 22:12 ro0gr

@ro0gr just for the sake of discussion, would be great to ditch ember-native-dom-helpers as well as ember-cli-node-assets for v2

SergeAstapov avatar Jan 06 '22 02:01 SergeAstapov

@SergeAstapov, yes, with the #560 on board I'm going to finish my embroider effort(#556), and that's when I plan to drop the ember-cli-node-assets for sure.

As for the ember-native-dom-helpers, it should be removed together with the moduleFor adapters removal, which is also planned to be done after the #560(TBH it could be done independently of the [email protected] PR, but at the moment it seems reasonable to me to move the [email protected] to the finish line first).

ro0gr avatar Jan 06 '22 19:01 ro0gr

Just as a data point: Update from beta.3 to beta.3 was smooth for us, no problems to report.

jrjohnson avatar Aug 01 '22 16:08 jrjohnson

updated to beta.5, equally uneventful ✅

jrjohnson avatar Nov 21 '22 06:11 jrjohnson

🎉 awesome work @ro0gr!

jrjohnson avatar Mar 06 '23 16:03 jrjohnson