ember-cli-page-object
ember-cli-page-object copied to clipboard
WIP: feature hookable
TODO:
- [x] @san650 Is API ok?
- [ ] Add support for the async
before
andafter
hooks? - [ ] Tests
- [ ] Docs
@san650 Is there any other use cases that I need to make sure works correctly?
For what I see, the use case only exists for the clickable/fillable
functions, but with this API it can be used with all functions passing functions as hooks
I'll proceed once we resolve all questions and API is approved
I've been looking for a feature like this. It's great for adding before and after assertions on the action. Hope we can move forward with this.
@san650 What's your thoughts on this?
@artemgurzhii I think its a great! I would love to see this feature in master. Can you rebase and fix the tests? CI is failing
@san650 sure, I will work on it during those weekends and hope this will be ready by Monday.
What about the second question? Do you think there is any possible use case for the async hooks?
@artemgurzhii
@san650 Is there any other use cases that I need to make sure works correctly?
No that I can think of, but I'll let you know if something comes to mi mind.
Thanks!!