ember-cli-page-object icon indicating copy to clipboard operation
ember-cli-page-object copied to clipboard

WIP: feature hookable

Open artemgurzhii opened this issue 5 years ago • 7 comments

Issue

TODO:

  • [x] @san650 Is API ok?
  • [ ] Add support for the async before and after hooks?
  • [ ] Tests
  • [ ] Docs

@san650 Is there any other use cases that I need to make sure works correctly?

For what I see, the use case only exists for the clickable/fillable functions, but with this API it can be used with all functions passing functions as hooks

artemgurzhii avatar May 03 '19 12:05 artemgurzhii

I'll proceed once we resolve all questions and API is approved

artemgurzhii avatar May 03 '19 12:05 artemgurzhii

I've been looking for a feature like this. It's great for adding before and after assertions on the action. Hope we can move forward with this.

ming-codes avatar Oct 04 '19 17:10 ming-codes

@san650 What's your thoughts on this?

artemgurzhii avatar Oct 04 '19 18:10 artemgurzhii

@artemgurzhii I think its a great! I would love to see this feature in master. Can you rebase and fix the tests? CI is failing

san650 avatar Oct 04 '19 18:10 san650

@san650 sure, I will work on it during those weekends and hope this will be ready by Monday.

What about the second question? Do you think there is any possible use case for the async hooks?

artemgurzhii avatar Oct 04 '19 18:10 artemgurzhii

@artemgurzhii

@san650 Is there any other use cases that I need to make sure works correctly?

No that I can think of, but I'll let you know if something comes to mi mind.

Thanks!!

san650 avatar Oct 04 '19 18:10 san650

Coverage Status

Coverage decreased (-0.5%) to 98.283% when pulling 64d0023cc00864397b963f74202ed205e1c0cc3c on artemgurzhii:feature/hookable into 1dac34d70d7125f88ebdbc0a4278d57a58f1dade on san650:master.

coveralls avatar Oct 19 '19 13:10 coveralls