Data4ALL icon indicating copy to clipboard operation
Data4ALL copied to clipboard

Add search bar to find datasets.

Open samz5320 opened this issue 3 years ago • 21 comments

samz5320 avatar Oct 01 '21 05:10 samz5320

hey, would you like me to work on this issue :smiley: .

bineetNaidu avatar Oct 01 '21 05:10 bineetNaidu

Sure go ahead.

samz5320 avatar Oct 01 '21 05:10 samz5320

could u add more details to it?

bineetNaidu avatar Oct 01 '21 05:10 bineetNaidu

We could create a search bar where we can search using dataset names .. we can also add options to filter by color/level of dataset[beginner,intermediate,advance]

samz5320 avatar Oct 01 '21 05:10 samz5320

Hey , can i work on this issue if no one is currently working on this issue. I have a good knowledge of Javascript , HTML and CSS.

amRohitKumar avatar Oct 02 '21 14:10 amRohitKumar

Hey bro, I can make it if you assign me

LokeshRathore353 avatar Oct 02 '21 15:10 LokeshRathore353

both of you can try but i would be choosing the best one. and then u can keep adding changes to it .. can we do that?

samz5320 avatar Oct 02 '21 16:10 samz5320

ok Thanks a lot bro I'll try my best

On Sat, Oct 2, 2021 at 9:41 PM Sanjay Aradhyamath @.***> wrote:

both of you can try but i would be choosing the best one. and then u can keep adding changes to it .. can we do that?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/samz5320/Data4ALL/issues/3#issuecomment-932776800, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKN24DYJ34ZNVGM534VH5TUE4VJTANCNFSM5FD2MFYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

LokeshRathore353 avatar Oct 02 '21 16:10 LokeshRathore353

thanks , i'll give my best.

amRohitKumar avatar Oct 02 '21 16:10 amRohitKumar

Hey can you please assign me this task, i will be very grateful.

amRohitKumar avatar Oct 02 '21 17:10 amRohitKumar

Assigned both of you.

samz5320 avatar Oct 02 '21 18:10 samz5320

@samz5320 can you please explain me the idea of filter by level as there are links already for all three levels .

amRohitKumar avatar Oct 02 '21 18:10 amRohitKumar

A type of filter already exists. u can click on the links in the navbar to see them. We should be able to filter datasets depending on their difficulties. Also it should be compatible when we change the difficulties of already existing datasets.

samz5320 avatar Oct 02 '21 18:10 samz5320

Ig u misunderstood me , I was saying that as there are links already present in the navbar to filter accorging to levels, so do i need to add one more filter ? 'couz you said "we can also add options to filter by color/level of dataset[beginner,intermediate,advance]"

amRohitKumar avatar Oct 02 '21 18:10 amRohitKumar

Then no required ig. Just the search bar for. now

samz5320 avatar Oct 03 '21 02:10 samz5320

please review my pr

amRohitKumar avatar Oct 03 '21 03:10 amRohitKumar

will you please assign it to me.

Ankita-Nandkumar-Patil avatar Oct 03 '21 10:10 Ankita-Nandkumar-Patil

@samz5320 can you please review my pr and if any changes require, do let me know !

amRohitKumar avatar Oct 03 '21 12:10 amRohitKumar

Can you please assign this issue to me. I can fix this.

Ritika457 avatar Oct 03 '21 14:10 Ritika457

search bar has been implemented . if any changes or enhancements to the existing search bar are welcome

samz5320 avatar Oct 06 '21 08:10 samz5320

@samz5320 can you assign this task to me

yas-sisodia avatar Oct 14 '21 22:10 yas-sisodia