Data4ALL icon indicating copy to clipboard operation
Data4ALL copied to clipboard

Hover transition to navbar

Open yashnerkar opened this issue 2 years ago • 5 comments

Description

Added hover transition to Navbar which fits according to the dark and light theme as well as according to the site's overview.

Fixes # 143

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Explain the Testing instructions

Test Configuration:

  • Operating system:
  • Version:
  • Text-editors used:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS

yashnerkar avatar Oct 15 '21 22:10 yashnerkar

✔️ Deploy Preview for zen-visvesvaraya-18f5e7 ready!

🔨 Explore the source changes: 4ea30c966d2c991e217768d3bcc3fced37354775

🔍 Inspect the deploy log: https://app.netlify.com/sites/zen-visvesvaraya-18f5e7/deploys/616b34710eca1b0007413935

😎 Browse the preview: https://deploy-preview-143--zen-visvesvaraya-18f5e7.netlify.app

netlify[bot] avatar Oct 15 '21 22:10 netlify[bot]

Hey, there this is my first open-source contribution. I hope you allowed my pull request!

yashnerkar avatar Oct 16 '21 10:10 yashnerkar

small change instead of copy-pasting the whole CSS file can u only past ur changes so that it is easy for me to review which lines have changed?

samz5320 avatar Oct 16 '21 18:10 samz5320

okay np!

yashnerkar avatar Oct 16 '21 19:10 yashnerkar

Actually, I have done with this but with new PR. commit as only hover transition.

yashnerkar avatar Oct 16 '21 20:10 yashnerkar