evercookie icon indicating copy to clipboard operation
evercookie copied to clipboard

Prior code buggy, ineffective.

Open devayes opened this issue 9 years ago • 1 comments

Echoing output before headers, this (from original source) is more simple and works. If the cookie does not exist, respond with 304 Not Modified (ie: cached, evercookie.js: line #446 )

devayes avatar Jul 05 '14 07:07 devayes

Hi @devayes, it looks like this was changed primarily in this commit: commit e3bc6c613d5c8a2772c1fff02da3d438b5da62b6 Author: Tom McKenzie [email protected] Date: Mon Jun 18 13:36:42 2012 +1000

Return blank 500 error when apache_request_headers doesn't exist
(prevents evercookie from being set to the PHP error message)

I'd investigate/document why it changed dramatically further before we change all the code in this one

samyk avatar Sep 16 '14 17:09 samyk