nodejs-pypi icon indicating copy to clipboard operation
nodejs-pypi copied to clipboard

Add mypy typings to project compatible with python 3.10 + run unit tests in CI

Open jacobdr opened this issue 2 years ago • 2 comments

This PR adds mypy type checking to all of our internal code -- whereas #8 added typing for our external code

I used pretty modern type syntax, therefore this PR now requires project developers (and our release machinery) to use Python 3.10 specifically (though really we could support 3.10+, I wanted to KISS for now)

jacobdr avatar Nov 07 '22 18:11 jacobdr

Happy to be tied to 3.10 for now and add these typings. All looks good, once the conflicts are fixed will merge.

samwillis avatar Nov 10 '22 09:11 samwillis

We should update 'DEVELOPMENT.md' to note the minimum python version.

samwillis avatar Nov 10 '22 09:11 samwillis