obsidian-simple-embeds
obsidian-simple-embeds copied to clipboard
samwarnick
Add a generic link preview source
I added an additional source which generates a generic link preview for links that failed to match with any other source. It can be toggled on or off like any of the other sources and adds a single dependency (link-preview-js).
I added a cache that saves fetched metadata into storage so it doesn't make new requests every time you toggle reading view on a page. There's also an option to clear it in the settings if the user wants to refetch out of date metadata or it can be disabled entirely.
Thanks for working on this—was something I considered doing, maybe as a separate plugin. I'm going to start taking a look today.
Sorry it's been a while, I started college last month and got busy. I swapped out the cache in settings for a JSON file in the vault that is loaded asynchronously. Generic preview defaults to false now and I've also removed the unused rollup json plugin dependency.
I'm really looking forward to this getting merged, I've been wanting solid dynamic embeds for any link in Obsidian since I started using it and this looks like it will be pretty nearly perfect!
@udbhav-s thanks a bunch for those changes. They're looking pretty good. One issue I'm seeing is that I'm getting an error because genericPreviewCache.json does not exist. So it seems like the promise that creates/reads that file does not get called. Also might want to use this.app.vault.configDir + "/plugins/simple-embeds/" to save the file in the plugin rather than the vault. I've seen other plugins do that, so I think that might be the preferred way.
I know you're probably busy with school, so I'll make some time this next week to take a deeper look and see if I can make a fix. But if you're able to take a look, even better.
Looks like I wasn't awaiting the Promise that checked if the file didn't exist before creating it, should be fixed now! Also changed the location of the cache file to be in the plugin directory.
@udbhav-s thanks so much! Seems to be working pretty well on desktop, so I'm going to go ahead and merge this. I did notice that it's not working on iOS. I suspect that cheerio, a dependency of link-preview-js uses some apis not available on iOS. So after I merge this I will make a couple changes to make it so this will only run on desktop for now. And I'll make another issue to look into getting it to work on iOS. Should hopefully get it ready to be released later today.
Thanks again for this!
This is great, but it doesn't seem like this works in Live Preview mode? I do have "Show Embeds in Live Preview (beta)" enabled, but I only see the link previews when I switch to standard preview mode.
