protractor-gherkin-cucumberjs-angular icon indicating copy to clipboard operation
protractor-gherkin-cucumberjs-angular copied to clipboard

update to webpack 2.2.x

Open samvloeberghs opened this issue 8 years ago • 8 comments

Updating to webpack 2.2.x requires quite a lot of work in the webpack configs ..

samvloeberghs avatar Feb 07 '17 10:02 samvloeberghs

remove HMR bloat from example project

samvloeberghs avatar Mar 22 '17 08:03 samvloeberghs

Please see my comment on #55 I have this running in an angie4 cli/webpack 2.2.x project and for the most part, the webpack config is hidden with the cli -thank God (I may be missing something though :)).

Fiontan avatar May 07 '17 20:05 Fiontan

I actually have this update available in a local branch, just need to launch the PR. However, if we are going to use Angular CLI these changes might be obsolete. Let me know how you guys wish to proceed.

DennisJaamann avatar May 15 '17 10:05 DennisJaamann

I'm not completely in favour of using CLI.. If you can update @DennisJaamann, please do

samvloeberghs avatar May 15 '17 10:05 samvloeberghs

@samvloeberghs Hi Sam...can you expand upon the "not completely in favour of using CLI" comment please?

Fiontan avatar May 15 '17 12:05 Fiontan

I like to keep it configurable.. I also have the impression that CLI makes you "stupid" about the use of webpack.. You said you were glad that the webpack config did not need exposed.. Well I don't mind cause I've been doing webpack for years :p

to be honest I never saw the added value of cli, except for the nice working configuration.

samvloeberghs avatar May 15 '17 13:05 samvloeberghs

I understand Sam although there are rumours that the angular cli team are working on a plugin system for configurability- I think this is a good thing particularly for angular applications as it means that everything will be more standardised. This is your repo and so your direction is paramount although I for one would rather not be fighting with webpack configuration when I could be developing. For example, I mentioned that the register specs were not running correctly after I upgraded to ang4 webpack latest/cli. I suspect this may be something hidden away in the ang cli default webpack config, but wouldn't know where to start to investigate- and this is a common problem with webpack- those that understand it well are few and far between and for me, this is a major drawback for application teams.

Fiontan avatar May 15 '17 13:05 Fiontan

@Fiontan I favor the wishes of the community over mine: please see https://github.com/samvloeberghs/protractor-gherkin-cucumberjs-angular/issues/56. So I am in favor of moving to cli. There are some requirements tough.. To be honest I don't have the time right now to do it, so if you and/or @DennisJaamann want to be of help, please.

samvloeberghs avatar May 15 '17 13:05 samvloeberghs