SVPullToRefresh icon indicating copy to clipboard operation
SVPullToRefresh copied to clipboard

don't use strings for store empty custom views

Open pingwinator opened this issue 11 years ago • 3 comments

You save empty view like @"" strings. 0_o

- (void)setCustomView:(UIView *)view forState:(SVPullToRefreshState)state {
    id viewPlaceholder = view;

    if(!viewPlaceholder)
        viewPlaceholder = @"";

    if(state == SVPullToRefreshStateAll)
        [self.viewForState replaceObjectsInRange:NSMakeRange(0, 3) withObjectsFromArray:@[viewPlaceholder, viewPlaceholder, viewPlaceholder]];
    else
        [self.viewForState replaceObjectAtIndex:state withObject:viewPlaceholder];

    [self setNeedsLayout];
}

It's look copy-paste from

- (void)setSubtitle:(NSString *)subtitle forState:(SVPullToRefreshState)state {
    if(!subtitle)
        subtitle = @"";

    if(state == SVPullToRefreshStateAll)
        [self.subtitles replaceObjectsInRange:NSMakeRange(0, 3) withObjectsFromArray:@[subtitle, subtitle, subtitle]];
    else
        [self.subtitles replaceObjectAtIndex:state withObject:subtitle];

    [self setNeedsLayout];
}

This change is Reviewable

pingwinator avatar Jul 12 '13 12:07 pingwinator

AFAIK this is how you set a text label to be blank... [NSNull null] will display "(null)" no?

Why the images?

samvermette avatar Sep 26 '13 16:09 samvermette

no, I said it only for custom view

pingwinator avatar Sep 26 '13 17:09 pingwinator

Still don't get it. What's the problem with setting blank strings for custom view?

samvermette avatar Sep 28 '13 02:09 samvermette