ldp icon indicating copy to clipboard operation
ldp copied to clipboard

Integrating Lando and updating the usage of fcrepo4 for test suites, along with integrating WebMock

Open jrgriffiniii opened this issue 3 years ago • 6 comments

These proposed changes ensure that the usage of fcrepo4 as an LDP server do not break the existing test suite (this is necessary for advancing https://github.com/samvera/active_fedora/issues/1470)

jrgriffiniii avatar Jul 21 '22 12:07 jrgriffiniii

Coverage Status

Coverage: 86.284% (+0.1%) from 86.165% when pulling 90024c82da0bdc123025bae2d0b7b2c22373ac08 on allow-ruby-3.0-fcrepo4 into 155f15f0d07e8d3eee1ff0e5a8a17f9117333299 on allow-ruby-3.0.

coveralls avatar Aug 01 '22 20:08 coveralls

i've had trouble getting a basic lando environment running in the past, and wonder what it's adding over using docker-compose directly in this case?

no-reply avatar Aug 01 '22 23:08 no-reply

I am not certain why Ruby 2.7/Rails 5.2 is failing, but this can be at least squashed now that this is passing for the other Ruby/Rails releases.

jrgriffiniii avatar Aug 02 '22 13:08 jrgriffiniii

https://github.com/samvera/active_fedora/tree/issues-1479-jrgriffiniii-faraday1.0 needs to be rebased, and there still seem to be some problematic issues in integrating this branch.

jrgriffiniii avatar Aug 02 '22 20:08 jrgriffiniii

Coveralls is yielding inconsistent results for me, I am going to explore integrating simplecov as an alternative.

jrgriffiniii avatar Jan 26 '23 18:01 jrgriffiniii

For some reason the test coverage needed to be increased following these upgrades, however this should be ready for review.

jrgriffiniii avatar Jan 30 '23 14:01 jrgriffiniii