hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

update for sort-dropdown to address accessiblity issues.

Open trmccormick opened this issue 1 month ago • 1 comments

Fixes

Fixes #7235 ; refs #7235

Summary

Improve accessibility and localization of sort dropdowns in the search interface.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Sort dropdowns now use descriptive, internationalized labels instead of icons.
  • All sort options are clearly labeled and accessible to screen readers.
  • Sort labels are consistent across all supported locales.
  • No runtime errors occur when rendering sort fields.

Type of change (for release notes)

notes-bugfix Bug Fixes

Detailed Description

This PR updates the sort dropdowns in the search interface to enhance accessibility and localization:

  • Replaces triangle icons with text labels for sort options.
  • Uses i18n translation keys for all sort labels.
  • Ensures translation keys are present in all major locale files.
  • Fixes runtime error caused by lambda usage in Blacklight sort configuration.

Changes proposed in this pull request:

  • Update sort field configuration to use direct i18n string lookups.
  • Add missing translation keys for sort labels to all major locale files.
  • Remove lambda usage from sort label configuration to resolve runtime error.

@samvera/hyrax-code-reviewers

trmccormick avatar Dec 03 '25 22:12 trmccormick

Test Results

    13 files  ±0      13 suites  ±0   2h 50m 5s ⏱️ - 3m 13s  6 953 tests  - 1   6 645 ✅  - 3  306 💤 ±0  2 ❌ +2  18 504 runs  ±0  17 999 ✅  - 4  501 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit b2e17775. ± Comparison against base commit 2f4eb6fd.

This pull request removes 367 and adds 366 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0b9c7d8d50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3c61790140>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff08df40788>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0b9cb9fc90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3c5df2e748>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff086c48988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 6815b5fe-87b1-403c-ac4b-41b5410abcc0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2edd8b4d-8d1a-46fc-a2fa-81933322c354
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 72152b09-8681-4506-8e0c-a008f42520cf
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a86c093a-496c-464a-8bb3-fb023d3d8b43
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7c352aac98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8990dbe248>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fde1d427e50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7c351b7098>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8990c28208>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fde1dad8fd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f7ea3e01-c1de-4c77-aec1-0534f76a61fb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 5e15391b-b917-42dd-86ed-d80412d1bf81
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 6edc0738-1549-4550-b852-3bcd1dd7ab76
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 910090d2-410b-41c9-b99a-c9c646301da3
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 03 '25 23:12 github-actions[bot]