Update _form_for_select_collection.html.erb

[rkuehn-uofl]

Added labels for "member_of_collection_*"

Fixes

Fixes #6500

Summary

Adds labels for member_of_collection_label and member_of_collection_ids

Guidance for testing, such as acceptance criteria or new user interface behaviors:

• Go to the Works page: https://pg.nurax.samvera.org/dashboard/my/works?locale=en
• Click the WAVE plugin to view the report

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

• notes-accessibility Accessibility Fixes

Detailed Description

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

<div class="modal-body">
          <% if user_collections.blank? %>
            <em> <%= t("hyrax.collection.select_form.no_collections") %></em><br /><br /><br /><br />
          <% else %>
            <div class="collection-list">
              <div class="form-group">
                <p><%= t("hyrax.collection.select_form.select_heading") %></p>
              
                <% if @add_works_to_collection.present? %>
                  <label for=""><%= t("hyrax.collection.select_form.select_label") %></label>
                  <%= text_field_tag 'member_of_collection_label', @add_works_to_collection_label, disabled: true %>
                  <%= hidden_field_tag 'member_of_collection_ids', @add_works_to_collection %>
                <% else %>
                  <label for="member_of_collection_ids"><%= t("hyrax.collection.select_form.select_label") %></label>
                  <%= text_field_tag 'member_of_collection_ids', nil,
                              prompt: :translate,
                              data: {
                                placeholder: t('simple_form.placeholders.defaults.member_of_collection_ids'),
                                autocomplete: 'collection',
                                'autocomplete-url' => Rails.application.routes.url_helpers.qa_path + '/search/collections?access=deposit'
                              } %>
                <% end %>
            
              </div>
            </div><!-- collection-list -->
          <% end %> <!-- else -->
        </div>

@samvera/hyrax-code-reviewers

[github-actions[bot]]

Test Results

    12 files   -     1      12 suites   - 1   2h 17m 11s ⏱️ - 24m 0s  6 492 tests  -   340   6 227 ✅  -   306  265 💤  - 34  0 ❌ ±0  16 352 runs   - 1 750  15 923 ✅  - 1 702  429 💤  - 48  0 ❌ ±0 

Results for commit 280d7656. ± Comparison against base commit b9ff7bc0.

This pull request removes 710 and adds 370 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f29d3cfd498>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4ca4986190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9a071480e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f29d76ba780>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4ca499af00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9a07cc3208>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 2b4d5971-7458-4449-8b5d-3dea90993406
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 91a40e52-0ee9-4249-88be-809e5fc11092
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b6db4f5a-f032-42dd-ad7a-84ff109976ca
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b2cab91e-0dbf-4104-8b20-41cdbf165c12
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5e3c4307a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f644c2f3fc0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f83a9f8eec0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5e3c23fdd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f644c2a8840>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f83aa03cd18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ab2c06d1-1ad8-427a-b22c-617881ce3866
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 133ff165-ef64-4f1a-a9c2-fb07edea2ff4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7d1e4d06-5de0-432f-8284-c5a48b5b44e0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c9dcbcf5-ceae-4847-99d5-b653f7d994b3
…

This pull request skips 16 tests.

spec.controllers.hyrax.dashboard.collections_controller_spec ‑ Hyrax::Dashboard::CollectionsController with model Collection #create creates a Collection with old style parameters
spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#permission_template when the PermissionTemplate doesn't exist gets created
spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#permission_template when the PermissionTemplate exists uses the existing template
spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#select_files with a work/file attached returns a hash of with file title as key and file id as value
spec.forms.hyrax.forms.resource_form_spec ‑ Hyrax::Forms::ResourceForm#version when using wings prepopulates as empty before save
spec.forms.hyrax.forms.resource_form_spec ‑ Hyrax::Forms::ResourceForm#version when using wings with a saved work prepopulates with the etag
spec.jobs.migrate_files_to_valkyrie_job_spec ‑ MigrateFilesToValkyrieJob it migrates all derivatives along with a file
spec.jobs.migrate_resources_job_spec ‑ MigrateResourcesJob#perform migrates a file set by its id
spec.jobs.migrate_resources_job_spec ‑ MigrateResourcesJob#perform migrates admin sets to valkyrie
spec.lib.hyrax.analytics_spec ‑ Hyrax::Analytics configuration When the yaml file has a deprecated format reads its config from a yaml file
…

:recycle: This comment has been updated with latest results.

[randalldfloyd]

@rkuehn-uofl I think the issue with the test failures is that the new labels being added use a key that doesn't exist in the locales:

hyrax.collection.select_form.select_label

[randalldfloyd]

@rkuehn-uofl Reports that this may be resolved as the page no longer reports the original issue.