hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

WIP Bootstrap 5

Open dlpierce opened this issue 1 year ago • 2 comments

Fixes

Fixes #6904

Summary

Upgrade to Bootstrap 5

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Website loads with no major layout style issues

Changes proposed in this pull request:

  • Update to Bootstrap 5 framework, modifying JS and SCSS as needed.

dlpierce avatar Oct 02 '24 19:10 dlpierce

Currently blocked by changes needed in Browse Everything:

SassC::SyntaxError: Error: The target selector was not found. (SassC::SyntaxError)
db_migrate-1  |        Use "@extend .mr-2 !optional" to avoid this error.
db_migrate-1  |         on line 73 of ../../bundle/ruby/3.2.0/gems/browse-everything-1.3.0/app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss
db_migrate-1  | >>       @extend .mr-2;

dlpierce avatar Oct 02 '24 19:10 dlpierce

Test Results

0 files   -     17  0 suites   - 17   0s :stopwatch: - 2h 23m 27s 0 tests  -  6 705  0 :white_check_mark:  -  6 407  0 :zzz:  - 297  0 :x:  - 1  0 runs   - 13 180  0 :white_check_mark:  - 12 784  0 :zzz:  - 395  0 :x:  - 1 

Results for commit d3f70314. ± Comparison against base commit aeb5e3e5.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 02 '24 19:10 github-actions[bot]