hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

unsupported ARIA attribute in pagination

Open rjkati opened this issue 1 year ago • 3 comments

Descriptive summary

On dev.nurax.samvera.org (Hyrax 5.0.1), pagination includes an ARIA attribute which is not supported. This occurs whenever pagination appears:

Steps to reproduce the behavior in User Interface (UI)

  1. In Chrome, download the Site Improve browser extension
  2. Go to https://dev.nurax.samvera.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q= and run the Site Improve browser extension aria-pagination

rjkati avatar Jun 21 '24 15:06 rjkati

I could reproduce in pg but not dev for both search results and all works.

Search results:

Image

Image

All works: Image

Image

aahurford avatar Nov 05 '24 02:11 aahurford

Hi @rjkati

Regaring the /catalog view the ARIA attribute is set by Blacklight gem

image

To address this issue in the Hyrax gem, the only solution would be to override the Blacklight gem's view. Would this approach be acceptable?

rodyoukai avatar Dec 09 '24 23:12 rodyoukai

Unable to reproduce (test links below).

Hyrax v5.1.0-beta1 Links: Example link from above without search term (error - page doesn't exist) -

  1. https://dev.nurax.samvera.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q

Example link from above with search term -

  1. https://dev.nurax.samvera.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q=test

Koppie v5.1.0-beta1 Links:

  • https://f6.nurax.samvera.org/catalog?search_field=all_fields&q=

  • https://f6.nurax.samvera.org/catalog?search_field=all_fields&q=test

Image

rkuehn-uofl avatar Apr 16 '25 11:04 rkuehn-uofl