hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

Version Presenter Valykrization

Open marrus-sh opened this issue 2 years ago • 0 comments

I’ve been looking into editing FileSets through the Web UI in a Valkyrized Hyrax and from what I can tell the VersionListPresenter and VersionPresenter are current sticking points in making this work. I think fixing the following things would get us a fair chunk of the way there :—

  • [ ] FileSets need an original_file method. The ValkyrieFileSetIndexer provides an implementation of original_file here :—

    https://github.com/samvera/hyrax/blob/d5be603d9a01737145ffa2a8b9c6d8a9a1ca8641/app/indexers/hyrax/valkyrie_file_set_indexer.rb#L102-L106

    —: but it doesn’t appear to be present on FileSets themselves. Perhaps this method can just be moved there?

  • [ ] The resulting FileMetadata needs a versions method, and doesn’t have one. The Wings storage adapter provides a find_versions method so creating this should be achievable.

  • [ ] The Version object provided by the Wings storage adapter is missing a created method, although “in practice” it seems like this might be the version_token?

  • [ ] Finally, Versions created by Wings should have an associated VersionCommitter. VersionCommitters are created by the VersioningService, but this service does nothing for Valkyrie resources. The pieces to implement this for Wings should be present in the storage adapter; it just needs to be put into place.

marrus-sh avatar Sep 21 '22 01:09 marrus-sh