Cannot remove embargo from work

[jlhardes]

Descriptive summary

When testing locally using koppie and after a work has an embargo assigned, trying to deactivate the embargo results in an error message.

Expected behavior

A Deactivation successful message should appear and you should be able to verify that the embargo has been removed from the Work and the Work can be accessed.

Actual behavior

The following error message is shown when trying to deactivate an embargo on a work: Faraday::ConnectionFailed in Hyrax::PermissionsController#confirm

Steps to reproduce the behavior

1. Navigate to a Work which contains an embargo
2. Click the "Edit" button
3. In the "Save Work" box on the right side, click the "Embargo Management Page" link in the Visibility section
4. Click the "Deactivate Embargo" button
5. Error message appears (see screenshot)

Related work

#5572 Works cannot be saved if embargo or lease is assigned (nurax-pg) - in progress and available to test locally only but allows works to be saved with an embargo

[jlhardes]

Testing on koppie shows that the error screen isn't occurring anymore but the embargo is still not being removed. I see the green message that says it was successful but the Embargo badge is never changed to anything else. Additionally, the work title is not showing in the Embargo Management Page or in the interim screen when trying to Deactivate. I'm not sure if that is connected to the embargo not actually being removed, but maybe? The title of this work is supposed to be "Julie test embargo 1":

[gamontoya]

Seeing the same behavior Julie notes on Koppie.

[fritzfreiheit]

My bad. I was fooled into thinking the Embargo had been remove because the Embargo badge wasn't there. I'm looking into it.

[eporter23]

I deactivated the Embargo on this work: https://nurax-pg.curationexperts.com/concern/generic_works/90bcd2bb-c040-44f1-a795-bc4f7afcba35/edit?locale=en - the embargo appears to have been removed, but it does not show up on the Deactivated Embargoes list in Manage Embargoes.

[eporter23]

I created a new work and embargoed it, and tried to remove the embargo. I see a prompt to reset permissions to Private and proceed. No errors occur, but the work remains embargoed after several attempts. https://nurax-pg.curationexperts.com/concern/generic_works/9bc3f926-28c9-4165-bc71-0bf4adc7358f?locale=en

[gamontoya]

@rjkati

I can still replicate this issue on Koppie v4.0.0.rc3

[gamontoya]

@rjkati This now works on dev-nurax Hyrax Version: 4.0.0.rc3

However, it sets the visibility to Private even if I set it to be Public or Institution after embargo period ends.

[alishaevn]

this ticket only refers to embargoes, but it appear leases also aren't working. it's out of scope, but the work has begun on #6111.

[rjkati]

Confirmed that deactivating embargoes now works on pg.nurax