hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

Published 20 hours ago • verified publisher icon samvera

add checked option to radio button

Open kirkkwang opened this issue 2 years ago • 4 comments

Summary

Through radio buttons, give indicator what visibility the collection is currently set to. Tested change on Hyku.

Changes proposed in this pull request:

  • add checked option to radio button

Screenshot

hyrax-radio-button

kirkkwang avatar Jul 27 '22 20:07 kirkkwang

looks like the specs need updating to match the change?

no-reply avatar Jul 27 '22 22:07 no-reply

FWIW I tried this out locally and I'm not able to reproduce the original issue with hyrax's main branch, but I am able to reproduce it with nurax-dev.

cjcolvar avatar Jul 29 '22 15:07 cjcolvar

@cjcolvar looking closer, it seems like the form should prepopulate this data?

no-reply avatar Aug 09 '22 16:08 no-reply

@no-reply Do you think the form is already prepopulating in some cases but not for others? Could this be a valkyrie/activefedora form difference?

cjcolvar avatar Aug 09 '22 17:08 cjcolvar

Thanks Kirk! I ended up solving this in #5812 before I saw this PR. It was also solved by hyrax-head 12 which is why it wasn't showing up on main after the big hyrax 4 merge.

dlpierce avatar Aug 24 '22 13:08 dlpierce

Great thank you, @dlpierce !

kirkkwang avatar Aug 24 '22 18:08 kirkkwang