hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

Valkyrie: Edit collection using PcdmCollection raises exception undefined thumbnail_id

Open elrayle opened this issue 4 years ago • 3 comments

Descriptive summary

When Hyrax is configured with collection_model = "Hyrax::PcdmCollection", editing a collection raises exception undefined thumbnail_id.

Rationale

A collections should be able to be edited using the ActiveFedora::Base ::Collection or Valkyrie::Resource Hyrax::PcdmCollection. Eventually, all collection manipulation will be through Valkyrie.

Expected behavior

When editing a collection with collection_model = "Hyrax::PcdmCollection", expect the collection edit form to load.

Actual behavior

When editing a collection with collection_model = "Hyrax::PcdmCollection", raises exception undefined thumbnail_id.

image

Steps to reproduce the behavior

Prerequisite:

  • edit config/initializers/hyrax.rb and change or set config.collection_model to "Hyrax::PcdmCollection"
  • restart rails server
  • login and create a collection

To reproduce:

  1. Login
  2. Dashboard -> Collections
  3. Click the action menu beside an existing collection
  4. Select Edit collection

raises undefined thumbnail_id

Related work

See https://github.com/samvera-labs/nurax-pg/issues/27

elrayle avatar Dec 10 '21 20:12 elrayle

PR #5287 adds a check to skip the code that allows a user to select a thumbnail for the collection. When this issue is resolved, the skip should be removed.

elrayle avatar Dec 10 '21 20:12 elrayle

per #5764, we shouldn't undo the changes in #5287.

collection thumbnail selection is still a serious issue (for all model types), even after this ticket is closed.

no-reply avatar Jul 13 '22 17:07 no-reply