Update PcdmCollection metadata to match existing ::Collection metadata

[elrayle]

This is in preparation for using Hyrax::PcdmCollection for new/create in the collections controller. Partially addresses Issue #5132 Val MVP: Create PcdmCollection as a valkyrie resource through UI.

This issue update the metadata for Hyrax::PcdmCollection to match that currently provided through ::Collection.

Possible follow-on work:

• Currently, core metadata is included in collection_basic_metadata to allow title to have multiple values specified in the form. If there was support for overriding metadata with the last reference to an attribute taking precedence, then core_metadata can be included and an override for just title can happen in collection_basic_metadata.
• collection_metadata is an empty metadata file that allows sites to add additional metadata for collections by adding this file to their app and adding custom metadata definitions. This may need additional testing and may be dependent on override functionality being in place first.
• collection_basic_metadata does not bring in thumbnail selection into the form.
• Locations, driven by the based_near attribute, is not connecting to GeoNames for auto-complete. It is possible that there is some outside configuration that has to happen in the app for this to work and does not represent additional work in Hyrax. Testing needs to happen to confirm this.
• There is a larger question about what metadata should be included as collection metadata. This will require community input to determine if we want to make a change.

@samvera/hyrax-code-reviewers

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

[jlhardes]

Hopefully this is a helpful comment here: The descriptive fields on Collection are something that is part of Hyrax now (3.3.0) and we should keep those descriptive fields in place in Valkyrized Hyrax. I don't want to remove features from Hyrax moving forward. I can understand that collection level metadata might vary more between institutional implementations so if it is possible to provide an option to change/remove/override the collection descriptive fields, that seems reasonable, but since they are already part of Collections in current Hyrax, those fields need to remain part of the code base.

[marrus-sh]

We’re currently looking at using samvera-labs/houndstooth to provide metadata information for surfliner/comet (which is Hyrax‐ and Valkyrie‐based) and would like to define all non‐mission‐critical metadata fields in that way.

Ideally, I think we would be able to define our own collection as a subclass of Hyrax::PcdmCollection, setting it as Hyrax.config.collection_class (is that right?), and use the subclass definition to provide our own metadata. This is how we are currently handling objects (as a subclass of Hyrax::Work).

But that method won’t work if Hyrax::PcdmCollection necessarily loads a bunch of metadata already. A means to disable that metadata loading would be appreciated!

[elrayle]

@marrus-sh The last commit added documentation for how to override and/or extend metadata for collections. To remove all metadata defined in the basic metadata yaml file, all you need to do is create config/metadata/collection_basic_metadata.yaml in your app and set the contents to...

attributes = {}

Collections will continue to include core_metadata.yaml, which they did prior to this PR.

Any other concerns for the surfliner/comet use case?

[elrayle]

@marrus-sh I am exploring using a generator to create the valkyrie version of the collection class which would allow pushing the inclusion of default basic metadata out to that class. Then if you want to remove the basic metadata, you would simply comment out that line. This would be closer to what happens now with Works.

[marrus-sh]

@elrayle this all sounds workable to me—thanks for your efforts here :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

[tpendragon]

Collections are being created. I think it's possible all the metadata isn't there, but we're not seeing that in QA. Closing.