hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

App generated by template includes .fcrepo_wrapper for connecting to Fedora

Open elrayle opened this issue 4 years ago • 0 comments

Question

Are we ready to have the generated app be fully Valkyrized? Or should this change wait for a certain set of criteria to be met prior to committing this change?


Descriptive summary

When using Valkyrie for backend persistence, the .fcrepo_wrapper.yml file is no longer needed. Remove it from the generation process.

Rationale

When using Valkyrie for persistence, do not include Fedora specific files.

Expected behavior

Generating a new Hyrax app using template.rb should not create /.fcrepo_wrapper.yml.

Actual behavior

Generating a new Hyrax app using template.rb creates /.fcrepo_wrapper.yml.

Steps to reproduce the behavior

  1. Generate a new Hyrax app using...
rails _5.2.6_ new my_hyrax -m https://raw.githubusercontent.com/samvera/hyrax/v3.1.0/template.rb

NOTE: May need to adjust the tag from v3.1.0 to the latest version tag for Hyrax.

  1. check that /.fcrepo_wrapper.yml was not created

Related Work

Issue #5098 App generated through template includes file_set model that is an AF::Base model Issue #5099 App generated through template includes collection model that is an AF::Base model

elrayle avatar Sep 10 '21 21:09 elrayle