hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

Confusing screen reader label for Add files button within Create New Work page

Open mjgiarlo opened this issue 8 years ago • 3 comments

Issue by bnhowell Wednesday Feb 22, 2017 at 19:28 GMT Originally opened as https://github.com/projecthydra/sufia/issues/3102


Descriptive summary

Related to Sufia 7.2

Create New Work page (Add files tab): The “+ Add files ...” button control is labeled “Browse” is exposed to screen reader (JAWS) and "Choose files" (VoiceOver), which is not as descriptive a label for the control.

Markup should be:

<label>Add Files
<input type="file" name="files[]" multiple="">
</label>

Expected behavior

Control label (text element) matches button label

Actual behavior

Nothing here is describing the input type file.

Related work

mjgiarlo avatar Feb 27 '17 20:02 mjgiarlo

Comment by mjgiarlo Monday Feb 27, 2017 at 17:53 GMT


@bnhowell move to hyrax?

mjgiarlo avatar Feb 27 '17 20:02 mjgiarlo

Comment by bnhowell Monday Feb 27, 2017 at 19:22 GMT


great!

On Mon, Feb 27, 2017 at 12:53 PM, Michael J. Giarlo < [email protected]> wrote:

@bnhowell https://github.com/bnhowell move to hyrax?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/projecthydra/sufia/issues/3102#issuecomment-282796570, or mute the thread https://github.com/notifications/unsubscribe-auth/AQBqv7H2VJVvS5HJErPbcHY_sMuwPEgXks5rgw2IgaJpZM4MJFJF .

-- Ben Howell | Accessibility & User Experience Specialist Design & Discovery | LIT | University of Michigan Library [email protected]

mjgiarlo avatar Feb 27 '17 20:02 mjgiarlo

A WAVE browser test in Hyrax 3.5 and 4 beta2 shows that this element along with the Add Folder button does not actually have a label assigned, so this is still a problem.
Screen Shot 2023-01-27 at 8 34 19 AM

eporter23 avatar Jan 27 '23 13:01 eporter23