Review submissions dashboard not scoped as expected

[bess]

Descriptive summary

In Hyrax 2.1.0, as an admin, I expect to be able to go to the "Review Submissions" dashboard and see things that I need to review, and things that have completed the review process. However, the list of objects displayed in this view does not match my expectations when there are large numbers of Admin Sets and workflows in play.

Expected behavior

There are 138 published objects (where published is our final workflow state) in this repository:

I would expect that if I go to the "Published" tab in the Review Submissions dashboard, I should see 138 objects.

Actual behavior

However, logged in as an admin user who should have a role in all workflows, when I go to the Review Submissions dashboard to look at Published works, I only see 40:

Note that we had to override app/controllers/hyrax/admin/workflows_controller.rb in order to change the name of the final workflow state:

    self.deposited_workflow_state_name = 'published'

AFAICT, the Review Submissions screen works as expected for small numbers of objects spread across small numbers of admin sets and workflows. However, this repository has over twenty admin sets, which use several different workflows. I believe the scoping of the query for Review submissions isn't returning everything it should.

Steps to reproduce the behavior

Unfortunately I don't know how to reproduce this behavior easily without creating lots and lots of admin sets with different workflows. I'd be very interested to know if others are observing similar behavior.

[rjkati]

In Hyrax 3.0.0 rc3, there are 1,644 published objects on nurax-dev

The "Published" tab on the "Review Submissions" page shows 1,000 results.

[dlpierce]

I made a new issue about the 1000 result limit seen by rjkati. The original issue appears to be a separate problem.

Looking at the referenced issues where this was originally seen, @mark-dce was the original reporter. Do you still encounter this problem in your system, and if so, would it be possible to take a closer look at the solr documents for the affected works?

[mark-dce]

We have a repository with over 9,000 items, when I look at the dashboard, the Review items data-table seems to be artificially limited to 1,000 items. I don't believe this actually has to do with solr docs or admin sets, just a limit on the total number of items in the data tables?

[dlpierce]

Thank you, that is correct, that there is an artificial limit here. The original screenshots didn't have so many works, so the limit should not have been in effect. We will circle back around to check this again after we resolve the 1000 row limit.

[MPLSFedResearchTZ]

This problem has been out of date for the new Hyrax. A similar issue has been observed in Hyrax 3.3.0: https://github.com/samvera/hyrax/issues/5436.

[jlhardes]

The original report might still be a problem but what we can verify is what is described in #5436. I will leave this issue open and see if the number of works under the Works section matches or makes more sense in comparison to the number of works listed in the Review Submissions section after that issue is resolved.

[rjkati]

This issue is still present in my local build of Hyrax 4.0.0.beta1.

My local build has 26 published works:

However, the Review Submissions tab only shows 5 published works:

Is the intent of the "Published" tab on the "Review Submissions" screen to show all works which have been published in the repository? My understanding of this page was that it showed works which were previously under review and had been approved for publication. Therefore, the "Review Submissions" tab would not include works in the Default workflow, which could account for the discrepancy.

[no-reply]

@rjkati i'm honestly not clear at all about what the Published tab is supposed to show. the best approximation seems to be "objects that have completed the default workflow and are in it's terminal 'published' state". that's a weird thing to have hard coded in the repository, since workflows are otherwise configurable.

my read is that this whole view was written up to match a wireframe and for a plausible demo in the In-a-Box era, but was never really designed to work with a real repository with custom workflow needs. i'm not sure what next steps are for this. cc: @jlhardes @dlpierce