hydra-works icon indicating copy to clipboard operation
hydra-works copied to clipboard

Implement related objects for generic files if appropriate

Open elrayle opened this issue 10 years ago • 6 comments

If generic files can have related objects, then validate that the behavior is correctly inherited from pcdm:object. (See xit test Related objects -> persists in models/generic_file_spec.rb)

Otherwise, the behavior of adding related objects needs to be blocked in models/concerns/generic_file_behaviors.rb and the block tested.

elrayle avatar May 12 '15 21:05 elrayle

I thought related objects was out of scope and that further discussion would happen before implementing it.

jcoyne avatar May 12 '15 21:05 jcoyne

See discussionhttps://github.com/projecthydra-labs/hydra-pcdm/pull/66

jcoyne avatar May 12 '15 21:05 jcoyne

My understanding from issue https://github.com/projecthydra-labs/hydra-pcdm/pull/66 was that related files was being postponed. Related object code was already in place and functional from PR https://github.com/projecthydra-labs/hydra-pcdm/pull/68. This behavior is inherited from Hydra::PCDM. Tests were added with PR https://github.com/projecthydra-labs/hydra-works/pull/96. The ability to add related objects is now provided by services. See PR https://github.com/projecthydra-labs/hydra-works/pull/106. Tests for related objects moved from model tests to service tests with this PR.

If GenericFiles should not have related objects, then this functionality will need to be blocked.

elrayle avatar May 18 '15 01:05 elrayle

The related objects is being addressed again during the tech call on 2015-08-05.

grosscol avatar Aug 04 '15 14:08 grosscol

Refs projecthydra/sufia#1711

mjgiarlo avatar Jun 01 '16 19:06 mjgiarlo

This is still being addressed in a forthcoming release of Hyrax: https://github.com/samvera/hyrax/issues/116. It may also be deprecated by the Collections Extensions work (please see https://github.com/samvera/hyrax/issues/116#issuecomment-403633074)

jrgriffiniii avatar Aug 17 '18 18:08 jrgriffiniii