hydra-head icon indicating copy to clipboard operation
hydra-head copied to clipboard

Issue 557 - Assume client is requesting whole file if no range specified

Open bbpennel opened this issue 1 year ago • 2 comments

https://github.com/samvera/hydra-head/issues/557

If no range is specified for the Range header, then assume the whole file is being requested by overriding the range value to "0-". This prevents a error that we get frequently in our logs when clients provide the "Range: bytes=" header on their download requests.

@samvera/hydra-head

bbpennel avatar Mar 05 '24 20:03 bbpennel

Thanks for the clear writeup of the issue and this PR! It looks like the build is broken on an unrelated issue I think I saw on another samvera repo. I can resolve this in a separate PR but it might be a little while. Is getting this fix in urgent for you?

cjcolvar avatar Mar 06 '24 17:03 cjcolvar

No its not urgent, we have a local override which implements the same fix in the mean time.

bbpennel avatar Mar 06 '24 18:03 bbpennel