active_fedora icon indicating copy to clipboard operation
active_fedora copied to clipboard

Ruby 2.7 - warning: URI.escape is obsolete

Open prdanelli opened this issue 3 years ago • 1 comments

Hello, firstly, i would like to say thank you for the work you have invested in this project, its very much appreciated.

When using Ruby 2.7 and AF 12.2.x, Ruby gives a deprecation warning:

/usr/local/bundle/gems/active-fedora-12.2.3/lib/active_fedora/file.rb:182: warning: URI.escape is obsolete

According to this Ruby post, https://bugs.ruby-lang.org/issues/17309, the issue could be resolved by replacing all instances of URI.escape with URI::DEFAULT_PARSER.escape.

Is this something that is possible or would be welcomed as a PR?

Thank you, Paul.

prdanelli avatar Sep 30 '21 09:09 prdanelli

Yes, please make a PR if you are able.

jcoyne avatar Sep 30 '21 12:09 jcoyne