active_fedora icon indicating copy to clipboard operation
active_fedora copied to clipboard
verified publisher icon samvera

Is LoadableFromJson still relevant?

Open awead opened this issue 9 years ago • 3 comments

Now that .load_instance_from_solr is gone, is LoadableFromJson still relevant?

awead avatar Sep 15 '16 03:09 awead

I can't think of any other use for it.

jcoyne avatar Sep 15 '16 13:09 jcoyne

Maybe deprecate it then and remove in AF 12?

awead avatar Sep 15 '16 13:09 awead

ActiveFedora::LoadableFromJson actually contains 4 classes (in addition to its own extend ActiveSupport::Concern):

  • ActiveFedora::LoadableFromJson::SolrBackedMetadataFile
  • ActiveFedora::LoadableFromJson::SolrBackedResource
  • ActiveFedora::LoadableFromJson::SolrBackedResource::FakeQuery
  • ActiveFedora::LoadableFromJson::SolrBackedResource::FakeQuery::FakeStatement

Do we need to deprecate each of those in their initializers? Seems like a mess.

atz avatar May 31 '17 23:05 atz